[NEW] Adds preference to one-click-to-direct-message and basic functionality #7564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marceloschmidt
previously requested changes
Jul 25, 2017
| @@ -330,6 +330,8 @@ | |||
| "Clear_all_unreads_question": "Clear all unreads?", | |||
| "Click_here": "Click here", | |||
| "Click_here_for_more_info": "Click here for more info", | |||
| "Click_Direct_Message": "Click to Create Direct Message", | |||
| "Click_Direct_Message_Description": "Skip opening profile tab and goes straight to conversation", | |||
There was a problem hiding this comment.
Either Skips opening ... and goes ... or Skip opening ... and go ... -- I prefer the former.
There was a problem hiding this comment.
"Skip opening profile tab, instead go straight to conversation" :D
sampaiodiego
previously requested changes
Jul 25, 2017
|
@sampaiodiego what do you think should be the behavior when clicking on yourself or for users that don't have direct channel permission? |
|
@gdelavald when clicking on yourself or for users that don't have direct channel permission I think we should show the profile panel, like the old/default behavior. |
|
IMHO this should be an admin option instead of per user. The use case right now is to change the chat behavior to all users. We can add a sub setting in the future to change the default behavior per user. |
gdelavald
force-pushed
the
one-click-to-direct-message
branch
from
67585bb
to
8722ed9
Compare
rodrigok
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7436
This feature adds a preference to users who would prefer to skip opening the flex tab with personal information when clicking on a username/card and goes straight into direct message mode.