Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] message-box autogrow #8019

Merged
merged 2 commits into from
Sep 4, 2017
Merged

[FIX] message-box autogrow #8019

merged 2 commits into from
Sep 4, 2017

Conversation

karlprieb
Copy link
Contributor

@RocketChat/core

Closes #7978

image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8019 September 1, 2017 21:03 Inactive
@engelgabriel engelgabriel added this to the 0.59.0-rc.4 milestone Sep 2, 2017
@gdelavald
Copy link
Contributor

gdelavald commented Sep 3, 2017

There is a small issue when a text line has the right width for the message box, but when the side scroll appears it break the line, causing some flickering on the text by the toggle of line breaks. I'll try and get a recording of this.
Solution might be making it a little bit narrower so the line breaks earlier.
EDIT: Seems like the issue is the toggling between overflow: scroll everytime we update the text.

@karlprieb
Copy link
Contributor Author

@gdelavald fixed 👍

@rodrigok rodrigok merged commit c3277ff into develop Sep 4, 2017
@rodrigok rodrigok deleted the messagebox-autogrow branch September 4, 2017 23:59
rodrigok added a commit that referenced this pull request Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line-height of input box needs to be the same as the message area
4 participants