[FIX] Fix new room sound being played too much #8144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
commented
Sep 14, 2017
| @@ -1,14 +1,6 @@ | |||
| /* globals menu*/ | |||
|
|
|||
| Template.sideNav.helpers({ | |||
| hasUnread() { | |||
There was a problem hiding this comment.
not used helpers 🤷♂️
|
You rule! This was getting super annoying! Like it was sitting there demanding I pay it attention everytime the other person started typing or anything until I finally looked at it |
sampaiodiego
force-pushed
the
fix-new-room-sound
branch
from
94f994e
to
096672e
Compare
rodrigok
reviewed
Sep 15, 2017
client/notifications/notification.js
Outdated
| @@ -55,6 +55,17 @@ Meteor.startup(function() { | |||
| KonchatNotification.newMessage(notification.payload.rid); | |||
| } | |||
| }); | |||
|
|
|||
| RocketChat.Notifications.onUser('subscriptions-changed', function(action, sub) { | |||
There was a problem hiding this comment.
What happens when you was added while offline and open the chat after that in a new window? You will receive the subscriptions in another place, it will not be an change while logged in.
There was a problem hiding this comment.
I'm looking into it
There was a problem hiding this comment.
covered by dc0aa06 =)
rodrigok
approved these changes
Sep 16, 2017
rodrigok
added a commit
that referenced
this pull request
Sep 18, 2017
[FIX] Fix new room sound being played too much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
I removed logic from the template to a listener on the
subscription-changedstream, so the sound will play only when new data comes from server and not due to any random reactivity.I've also removed some calls to
Meteor.user()which adds reactivity to changes to any field of the current user, which was not desired, and replaced byMeteor.userId()(when the test was to see the user is logged in) and by a query on specific fields (this way if I care aboutsettingsfield my code will not reactivity ran if thestatusfield changes).