[FIX] Allow unknown file types if no allowed whitelist has been set (#7074) #8172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lawri-van-Buel
approved these changes
Sep 18, 2017
rodrigok
approved these changes
Sep 18, 2017
rodrigok
added a commit
that referenced
this pull request
Sep 18, 2017
[FIX] Allow unknown file types if no allowed whitelist has been set (#7074)
Closed
|
still cannot add custom file extensions to the whitelist, or did i miss something? |
|
It seems files without mime-types still can not be uploaded. Is there a way to make it work? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7074
This moves the type validity check down to fileUploadIsValidContentType(). This way the whitelist can be checked first, before denying uploads of unknown file types. This way unknown/undetected file types are allowed, if and only if the whitelist is completely empty.