Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Unify unread and mentions badge #8361

Merged
merged 1 commit into from
Sep 30, 2017
Merged

[NEW] Unify unread and mentions badge #8361

merged 1 commit into from
Sep 30, 2017

Conversation

karlprieb
Copy link
Contributor

@RocketChat/core

image

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8361 September 29, 2017 19:47 Inactive
@ggazzo
Copy link
Member

ggazzo commented Sep 29, 2017

don't do that =/

is the number 1 relative to quantity of mentions? or just mentions|unread? ugly and confuse =/

@marceloschmidt
Copy link
Member

marceloschmidt commented Sep 29, 2017 via email

@engelgabriel engelgabriel added this to the 0.59.0-rc.11 milestone Sep 30, 2017
@engelgabriel
Copy link
Member

engelgabriel commented Sep 30, 2017

The current way takes far too much space.

image

We can move to the old way (filled box or transparent background) but this PR is already an improvement.

@rodrigok please merge this and we can make another PR with the final version.

@ggazzo
Copy link
Member

ggazzo commented Sep 30, 2017 via email

@engelgabriel
Copy link
Member

@ggazzo you can do the PR for the old "filled box or transparent background" if your are so disappointed 😉

@engelgabriel engelgabriel merged commit 9f397a5 into develop Sep 30, 2017
@engelgabriel engelgabriel deleted the mentions-badge branch September 30, 2017 04:22
rodrigok pushed a commit that referenced this pull request Oct 3, 2017
[NEW] Unify unread and mentions badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants