Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Setting to disable MarkDown and enable AutoLinker #8459

Merged
merged 1 commit into from
Oct 11, 2017
Merged

[NEW] Setting to disable MarkDown and enable AutoLinker #8459

merged 1 commit into from
Oct 11, 2017

Conversation

rodrigok
Copy link
Member

@RocketChat/core

@rodrigok rodrigok added this to the 0.59.0-rc.13 milestone Oct 11, 2017
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-8459 October 11, 2017 01:05 Inactive
geekgonecrazy
geekgonecrazy approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@geekgonecrazy geekgonecrazy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise 👍 I wonder about being disabled by default though... I think might break expected behaviour

@rodrigok rodrigok merged commit dd0f358 into develop Oct 11, 2017
@rodrigok rodrigok deleted the improvements/md-autolinker-disable-option branch October 11, 2017 01:30
rodrigok added a commit that referenced this pull request Oct 11, 2017
@rodrigok
Merge pull request #8459 from RocketChat/improvements/md-autolinker-d…
941051c 
…isable-option

[NEW] Setting to disable MarkDown and enable AutoLinker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.59.0-rc.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rodrigok @geekgonecrazy @engelgabriel