[FIX] Contextual errors for this and RegExp declarations in IRC module #8656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
graywolf336
reviewed
Nov 4, 2017
| @@ -44,10 +44,13 @@ class IrcClient { | |||
| this.socket.setNoDelay; | |||
| this.socket.setEncoding('utf-8'); | |||
| this.socket.setKeepAlive(true); | |||
| this.connect = this.connect.bind(this); | |||
| this.onConnect = this.onConnect.bind(this); | |||
There was a problem hiding this comment.
Hmmm unless I'm missing something, doesn't this get overwrote by the next line?
There was a problem hiding this comment.
Derp, I was missing something. 🙈 so never mind!
|
Not sure if the failing test is because of my changes. Can we run the Travis CI build again? |
|
@Pharserror we moved to CircleCI, everything passed, I just updated your branch with our develop branch to run the CI again. |
rodrigok
approved these changes
Dec 4, 2017
This was referenced Dec 5, 2017
Closed
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Should Close #6902 and #7412
I say Should because I have not been able to deploy this remotely and have only tested the RC fixes locally.
I was getting several "this.someFunction is undefined" errors after enabling the IRC plugin via the admin panel in Chrome 61. I fixed these context errors by binding
thisto the functions that were giving theundefinedmessage in the constructor.Also, there are several
RegExp's that were declared such that the functions they were made to trigger were not being triggered. I changed the declarations and now I am seeing messages.