[NEW] Describe file uploads when notifying by email #8924
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7976
@RocketChat/core
Changed so it shows the filename and the description (it's translated to receiving user's language as well -
![image](https://user-images.githubusercontent.com/8591547/33145974-8ba3c47c-cfa9-11e7-8ac4-d296b9700c97.png)
Enviou um arquivo para você
stands forSent you a file
). I'm not adding an<img/>
as stated on the issue because uploaded files are by default protected so would show a broken image if the email not opened on logged in browser.Also changed how a regular message is sent:
![image](https://user-images.githubusercontent.com/8591547/33145921-54ad448e-cfa9-11e7-9679-3233a7687a26.png)
I've also fixed emails for empty messages with just only
![image](https://user-images.githubusercontent.com/8591547/33146304-c29710b4-cfaa-11e7-9988-b70f46d92d0c.png)
attachments
: