[NEW] Internal hubot support for Direct Messages and Private Groups

[ramrami]

@RocketChat/core

Before

Internal hubot only responded to public rooms (room.t = 'c')

After

Internal hubot respond to the enabled room types ( 'c' or 'd' or 'p')

Edit
The bot respond in private groups only if it's added to that group.

Closes #7550 (maybe 5191 also)

[reetp]

Nice if this could make it in to 60 :-)

[slyk]

I would like people to DM to my hubot.
Internal is working ok on channels, but that creates scrapyard of messages, that needed only for person who talks to hubot.

Was trying to edit snap files to fast get this feature, but can't do this because of protection :(

---

hubot-rocketchat adapter could use DM, but I wanted to use internal.

How could we add this to release?

[reetp]

@ramrami is there any chance you could look at this ?
It would be really good to have it fixed.

[ramrami]

@reetp It's ready to be merged. All we need is a review from core team members.

[reetp]

@rodrigok can one of the devs look at this?

A fix and PR has been languishing here for some while for a bug that has been open for ages. I don't understand why it has been ignored so long.

Thanks.

[geekgonecrazy]

Sorry guys some how this slipped by.

[reetp]

Thanks Aaron :-)

[reetp]

As far as I can see it fixes:
#3132
#5191
#7550

[reetp]

@ramrami is there anything that needs to be done so we can see this in the 0.62 release ?

[ramrami]

@reetp It's already approved by @geekgonecrazy, and it has been added to the 0.62.0 milestone. I'm not part of the team, so I can't merge it ^^

[geekgonecrazy]

We'll began merging PR's for 0.62.0 I believe this next week. No worries, I don't see any reason this won't land

[vaggeliskls]

Iam using 0.62.2 version of rocketchat on Centos with custom installation.
I have update the Enable for Public Channels, Enable for Direct Messages and Enable for Private Channels to true. Iam trying to do an bot help command but no response on private channels. On direct and public channels work perfectly. Any idea ?
P.S I had done this fix before it was merged and worked perfectly for all channels

Any idea ?

[ramrami]

@vaggeliskls Did you invite the bot to the private channel ?

[vaggeliskls]

Ok. Thanks you very much. I run /invite @rocket.cat and then @rocket.cat help and it worked. Fast response and really useful community.