Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Internal hubot support for Direct Messages and Private Groups #8933

Merged

Conversation

Projects
None yet
6 participants
@ramrami
Copy link
Contributor

commented Nov 23, 2017

@RocketChat/core

Before

Internal hubot only responded to public rooms (room.t = 'c')

After

Internal hubot respond to the enabled room types ( 'c' or 'd' or 'p')

Edit
The bot respond in private groups only if it's added to that group.

Closes #7550 (maybe 5191 also)

ramrami added some commits Nov 23, 2017

ramrami added some commits Nov 23, 2017

@reetp

This comment has been minimized.

Copy link

commented Dec 13, 2017

Nice if this could make it in to 60 :-)

@slyk

This comment has been minimized.

Copy link

commented Jan 9, 2018

I would like people to DM to my hubot.
Internal is working ok on channels, but that creates scrapyard of messages, that needed only for person who talks to hubot.

Was trying to edit snap files to fast get this feature, but can't do this because of protection :(


hubot-rocketchat adapter could use DM, but I wanted to use internal.

How could we add this to release?

@reetp

This comment has been minimized.

Copy link

commented Jan 19, 2018

@ramrami is there any chance you could look at this ?
It would be really good to have it fixed.

@ramrami

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2018

@reetp It's ready to be merged. All we need is a review from core team members.

@reetp

This comment has been minimized.

Copy link

commented Jan 21, 2018

@rodrigok can one of the devs look at this?

A fix and PR has been languishing here for some while for a bug that has been open for ages. I don't understand why it has been ignored so long.

Thanks.

@geekgonecrazy

This comment has been minimized.

Copy link
Member

commented Feb 5, 2018

Sorry guys some how this slipped by.

@geekgonecrazy geekgonecrazy added this to the 0.62.0 milestone Feb 5, 2018

@reetp

This comment has been minimized.

Copy link

commented Feb 5, 2018

Thanks Aaron :-)

@reetp

This comment has been minimized.

Copy link

commented Feb 5, 2018

As far as I can see it fixes:
#3132
#5191
#7550

@reetp

This comment has been minimized.

Copy link

commented Feb 15, 2018

@ramrami is there anything that needs to be done so we can see this in the 0.62 release ?

@ramrami

This comment has been minimized.

Copy link
Contributor Author

commented Feb 15, 2018

@reetp It's already approved by @geekgonecrazy, and it has been added to the 0.62.0 milestone. I'm not part of the team, so I can't merge it ^^

@geekgonecrazy

This comment has been minimized.

Copy link
Member

commented Feb 15, 2018

We'll began merging PR's for 0.62.0 I believe this next week. No worries, I don't see any reason this won't land

@rodrigok rodrigok merged commit 99928a1 into RocketChat:develop Feb 17, 2018

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog Your tests passed on CircleCI!
Details
ci/circleci: test-without-oplog Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

@rodrigok rodrigok referenced this pull request Feb 28, 2018

Merged

Release 0.62.0 #9935

@vaggeliskls

This comment has been minimized.

Copy link

commented Mar 14, 2018

Iam using 0.62.2 version of rocketchat on Centos with custom installation.
I have update the Enable for Public Channels, Enable for Direct Messages and Enable for Private Channels to true. Iam trying to do an bot help command but no response on private channels. On direct and public channels work perfectly. Any idea ?
P.S I had done this fix before it was merged and worked perfectly for all channels

Any idea ?
image

@ramrami

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2018

@vaggeliskls Did you invite the bot to the private channel ?

@vaggeliskls

This comment has been minimized.

Copy link

commented Mar 14, 2018

Ok. Thanks you very much. I run /invite @rocket.cat and then @rocket.cat help and it worked. Fast response and really useful community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.