[FIX] Changed oembedUrlWidget to prefer og:image and twitter:image over msapplication-TileImage #9012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sapplication-TileImage
|
|
graywolf336
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #7662
Changes order of preference from:
msapplication-TileImage | og:image | twitter:image
to
og:image | twitter:image | msapplication-TileImage
msapplication-TileImage specifies an image at the site level rather than the page level, and requires a background of a color specified to msapplication-TileColor to render correctly. (Currently only TileImage is used)
og:image and twitter:image are used to provide an image associated with the specific page they are specified on, and are probably closer to the intention of a link preview.
twitter:image may have an image sized to dimensions for the purposes of a twitter summary card, and are likely less appropriate to use than og:image when both are specified.