Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Make Custom oauth accept nested usernameField #9066

Merged
merged 4 commits into from
Dec 19, 2017
Merged

[NEW] Make Custom oauth accept nested usernameField #9066

merged 4 commits into from
Dec 19, 2017

Conversation

pierreozoux
Copy link
Contributor

@RocketChat RocketChat deleted a comment Dec 11, 2017
@RocketChat RocketChat deleted a comment Dec 11, 2017
geekgonecrazy
geekgonecrazy approved these changes Dec 12, 2017
View reviewed changes
Copy link
Member

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this actually works compared to the existing way.

@pierreozoux
Copy link
Contributor Author

pierreozoux commented Dec 12, 2017 •
edited
Loading

@geekgonecrazy Thanks! What is needed to get this merged?

@rodrigok rodrigok added this to the 0.60.0 milestone Dec 19, 2017
@rodrigok rodrigok merged commit 838278a into RocketChat:develop Dec 19, 2017
rodrigok added a commit that referenced this pull request Dec 20, 2017
@rodrigok
Merge pull request #9066 from pierreozoux/patch-1
a88a761 
[NEW] Make Custom oauth accept nested usernameField
@pierreozoux pierreozoux deleted the patch-1 branch January 2, 2018 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.60.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierreozoux @geekgonecrazy @rodrigok