New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Make Custom oauth accept nested usernameField #9066

Merged
merged 4 commits into from Dec 19, 2017

Conversation

Projects
None yet
3 participants
@pierreozoux
Copy link
Contributor

pierreozoux commented Dec 11, 2017

pierreozoux added some commits Dec 11, 2017

@RocketChat RocketChat deleted a comment from codacy-bot Dec 11, 2017

@RocketChat RocketChat deleted a comment from codacy-bot Dec 11, 2017

@geekgonecrazy
Copy link
Member

geekgonecrazy left a comment

👍 this actually works compared to the existing way.

@pierreozoux

This comment has been minimized.

Copy link
Contributor

pierreozoux commented Dec 12, 2017

@geekgonecrazy Thanks! What is needed to get this merged?

@rodrigok rodrigok added this to the 0.60.0 milestone Dec 19, 2017

@rodrigok rodrigok merged commit 838278a into RocketChat:develop Dec 19, 2017

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog Your tests passed on CircleCI!
Details
ci/circleci: test-without-oplog Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

rodrigok added a commit that referenced this pull request Dec 20, 2017

Merge pull request #9066 from pierreozoux/patch-1
[NEW] Make Custom oauth accept nested usernameField

@pierreozoux pierreozoux deleted the pierreozoux:patch-1 branch Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment