[FIX] make the cross icon on user selection at channel creation page work #9176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlprieb
suggested changes
Dec 19, 2017
| @@ -146,6 +146,10 @@ Template.createChannel.events({ | |||
| const {username} = Blaze.getData(target); | |||
| t.selectedUsers.set(t.selectedUsers.get().filter(user => user.username !== username)); | |||
| }, | |||
| 'click .rc-icon'(e, t) { | |||
There was a problem hiding this comment.
I think you can be more specific here and use .rc-tags__tag-icon. There's a lot of rc-icon elements on this template.
karlprieb
approved these changes
Dec 20, 2017
rodrigok
added a commit
that referenced
this pull request
Dec 20, 2017
[FIX] make the cross icon on user selection at channel creation page work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
I found that the cross icon in the users selection thing wasn't working. So I fixed it for the project I'm working using RocketChat.
So I'm sending this PR in case you guys find it handy ; )
Also I'm sending a screenshot to make it clear of which part I'm talking about.