Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] i18n - add semantic markup #9534

Merged
merged 2 commits into from
Jun 7, 2018
Merged

[FIX] i18n - add semantic markup #9534

merged 2 commits into from
Jun 7, 2018

Conversation

brylie
Copy link
Contributor

@brylie brylie commented Jan 28, 2018

@RocketChat/core

I just noticed that the i18n file was using HTML tags to control aesthetics, rather than to indicate semantics. I.e. there was an H1 tag nested within an H2, which is not correct form. This PR corrects the header tag, and uses strong to emphasize the site name.

@CLAassistant
Copy link

CLAassistant commented Jan 28, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ engelgabriel
❌ brylie
You have signed the CLA already but the status is still pending? Let us recheck it.

@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-9534 June 7, 2018 18:37 Abandoned
@engelgabriel engelgabriel merged commit c1845df into RocketChat:master Jun 7, 2018
@sampaiodiego sampaiodiego mentioned this pull request Jun 16, 2018
@rodrigok rodrigok mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants