Including tab for listing room uploaded files #955
Conversation
|
How hard would it be to have images pop up in the lightbox? Right now you click an image it immediately downloads which is another deal all together. :) But looks very nice! |
|
@geekgonecrazy Great catch! I will have a look at this. |
| _id: 1 | ||
| 'file._id': 1 | ||
| limit: 50 | ||
| cursorFileMessages = RocketChat.models.Messages.find(msgQuery, msgOptions); |
There was a problem hiding this comment.
Can you change this to use a named query, like RocketChat.models.Messages.findMessagesWithFilesByRoomId?
|
@rodrigok Thanks for your review! I will have a look at those as well. |
|
@rodrigok suggested two great improvements:
I will work a bit more on this, thanks folks for the inputs! |
|
I think that's it for now! upload list swipebox |
|
This looks great! 👍 |
Including tab for listing room uploaded files
|
@gmsecrieru just pulled down on my production server. Looks like images still download. They show up in the preview but also still download. |
|
@geekgonecrazy You mean by clicking in the link from the Files List panel? What browser are you testing on? |
|
@gmsecrieru I was trying it in the electron app. Looks like it works fine in chrome. I may need to tweak things on the desktop app |
This PR closes #528 and we can improve UI/UX should the need arise.