Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Setting to configure max delta for 2fa #9732

Merged
merged 11 commits into from
Mar 15, 2018

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented Feb 15, 2018

@RocketChat/core
@sampaiodiego

Closes #6859

Screenshot

@RocketChat RocketChat deleted a comment Feb 15, 2018
@RocketChat RocketChat deleted a comment Feb 15, 2018
@RocketChat RocketChat deleted a comment Feb 15, 2018
@engelgabriel engelgabriel added this to the 0.62.0 milestone Feb 16, 2018
@engelgabriel engelgabriel added this to Desirable in 0.62.0 via automation Feb 16, 2018
@theorenck theorenck added this to Desireable in 0.63.0 via automation Feb 20, 2018
@theorenck theorenck removed this from Desirable in 0.62.0 Feb 20, 2018
@theorenck theorenck modified the milestones: 0.62.0, 0.63.0 Feb 20, 2018
@sampaiodiego sampaiodiego self-requested a review March 5, 2018 19:40
@@ -83,6 +83,14 @@ RocketChat.settings.addGroup('Accounts', function() {
public: true
});

this.section('Two Factor Authentication', function() {
this.add('Accounts_TwoFactorAuthentication_MaxDelta', 0, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have max delta as 1 by default? everything else LGTM

@rodrigok rodrigok merged commit 2892bf3 into RocketChat:develop Mar 15, 2018
0.63.0 automation moved this from Desireable to Done Mar 15, 2018
@rodrigok rodrigok mentioned this pull request Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.63.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants