Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NRR package to inside the project and convert from CoffeeScript #9753

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Move NRR package to inside the project and convert from CoffeeScript #9753

merged 2 commits into from
Feb 20, 2018

Conversation

rodrigok
Copy link
Member

@RocketChat/core

Closes #9544

Livechat still depends on old package

@rodrigok rodrigok added this to the 0.62.0 milestone Feb 17, 2018
@rodrigok rodrigok added this to Desirable in 0.62.0 via automation Feb 17, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9753 February 17, 2018 12:34 Inactive
@rodrigok rodrigok moved this from Desirable to Review/QA in 0.62.0 Feb 17, 2018
@rodrigok rodrigok self-assigned this Feb 17, 2018
@sampaiodiego
Copy link
Member

sampaiodiego commented Feb 17, 2018 •
edited
Loading

I don't see any reason for this =\

Especially if livechat will still depend on the old one

@engelgabriel
Copy link
Member

@sampaiodiego

Especially if livechat will still depend on the old one

Not for long.

@engelgabriel engelgabriel merged commit 88d305f into develop Feb 20, 2018
0.62.0 automation moved this from Review/QA to Done Feb 20, 2018
@engelgabriel engelgabriel deleted the move-nrr-inside branch February 20, 2018 02:43
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelgabriel engelgabriel engelgabriel approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

@rodrigok rodrigok

Labels
None yet
Projects
No open projects
0.62.0
  
Done
Milestone
0.62.0
Development

Successfully merging this pull request may close these issues.

Move Non-Reactive Render package into main project
3 participants
@rodrigok @sampaiodiego @engelgabriel