Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Change create channel icon #9851

Merged
merged 2 commits into from Feb 23, 2018
Merged

Conversation

karlprieb
Copy link
Contributor

@RocketChat/core

image

@karlprieb karlprieb added this to the 0.62.0 milestone Feb 22, 2018
@karlprieb karlprieb added this to Desirable in 0.62.0 via automation Feb 22, 2018
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-9851 February 22, 2018 21:50 Inactive
@karlprieb karlprieb moved this from Desirable to Review/QA in 0.62.0 Feb 22, 2018
@engelgabriel
Copy link
Member

@karlprieb you need to fix the test:

1) [Main Elements Render]
       [Side Nav Bar]
         render:
           it should show the new channel button:

      Uncaught AssertionError: expected false to be true
      + expected - actual

      -false
      +true

@rodrigok rodrigok changed the title Regression: change create channel icon Regression: Change create channel icon Feb 23, 2018
@rodrigok rodrigok merged commit 53be5e9 into develop Feb 23, 2018
0.62.0 automation moved this from Review/QA to Done Feb 23, 2018
@rodrigok rodrigok deleted the change-create-channel-icon branch February 23, 2018 20:10
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.62.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants