Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Misplaced "Save Changes" button in user account panel #9888

Merged
merged 1 commit into from
Feb 26, 2018
Merged

[FIX] Misplaced "Save Changes" button in user account panel #9888

merged 1 commit into from
Feb 26, 2018

Conversation

kaiiiiiiiii
Copy link
Contributor

@RocketChat/core

Closes #9886

This PR removes the hardcoded max-width in the user account panel which caused the save changes button to look different than in the admin ui.

Before:
screen shot 2018-02-24 at 16 31 12

After:
screen shot 2018-02-24 at 16 31 28

Admin UI:
screen shot 2018-02-24 at 16 38 25

@kaiiiiiiiii kaiiiiiiiii changed the title [FIX] "Saves changes" button in user account settings has hardcoded max-width [FIX] Misplaced "Save Changes" button in user account panel due to hardcoded max-width. Feb 24, 2018
@rodrigok rodrigok added this to Desirable in 0.62.0 via automation Feb 26, 2018
@rodrigok rodrigok added this to the 0.62.0 milestone Feb 26, 2018
@rodrigok rodrigok moved this from Desirable to Review/QA in 0.62.0 Feb 26, 2018
@rodrigok rodrigok changed the title [FIX] Misplaced "Save Changes" button in user account panel due to hardcoded max-width. [FIX] Misplaced "Save Changes" button in user account panel Feb 26, 2018
@rodrigok rodrigok merged commit df8ec68 into RocketChat:develop Feb 26, 2018
0.62.0 automation moved this from Review/QA to Done Feb 26, 2018
@kaiiiiiiiii kaiiiiiiiii deleted the remove_hardcoded_max_width_from_save_changes_button_in_user_account_ui branch February 26, 2018 17:18
@rodrigok rodrigok mentioned this pull request Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.62.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants