Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local development setup, custom logging, resolve channel name and username functions #102

Merged
merged 9 commits into from Jun 3, 2020

Conversation

AdarshNaidu
Copy link
Contributor

@AdarshNaidu AdarshNaidu commented May 23, 2020

This PR adds the following functions which will be used throughout the skill.

  • Local development setup: This allows the developer to run the logic (backend code) of the skill locally without having to upload the code to aws lambda function. Thus allowing faster development.

  • Custom Logging function: Displays logs to an external site which the developer can specify.

  • Resolve Channel names function: This function takes in a string as an input and returns an array of channel/group names which the user has joined and are similar to the input string

  • Resolve Usernames function: this function takes a string an an input and returns an array of usernames which the user is in contact with and is similar to the input string

@AdarshNaidu AdarshNaidu changed the title Essential functions Local development setup, custom logging, resolve channel name and username functions May 23, 2020
Copy link
Collaborator

@TheDreamSaver TheDreamSaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This custom logging feature can be included in a local development setup environment instead of the main code.

lambda/custom/helperFunctions.js Outdated Show resolved Hide resolved
lambda/custom/helperFunctions.js Outdated Show resolved Hide resolved
@AdarshNaidu
Copy link
Contributor Author

This custom logging feature can be included in a local development setup environment instead of the main code.

This will prevent the logs to show up when the skill will be hosted as a lambda function.
I think it can be removed completely after beta testing is finished.

Copy link
Collaborator

@TheDreamSaver TheDreamSaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this single best username or channel feature expected to vary per intent or this is like a global feature?

If it is global move the setting to the config file instead and use it from there.

Copy link
Collaborator

@TheDreamSaver TheDreamSaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the changes to the config file only.
No need for an additional file. The config is supposed to serve all the global configurations.

lambda/custom/helperFunctions.js Outdated Show resolved Hide resolved
@Sing-Li Sing-Li merged commit 5a1b4a0 into RocketChat:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants