Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fuselage): Add forwardRef to TopBarAction and SidebarAction #777

Merged
merged 3 commits into from
Jul 14, 2022

Conversation

guijun13
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • In order to remove the <Box> component in the sidebar action icons (Sort and CreateRoom) in the main RC repo, was needed to add a forwardRef to TopBarAction and SidebarAction components.

Issue(s)

Further comments

related PR: RocketChat/Rocket.Chat#26139

@ggazzo ggazzo changed the title feat(fuselage): Add forwardRef to TopBarAction and SidebarAction to fix icon spacing chore(fuselage): Add forwardRef to TopBarAction and SidebarAction to fix icon spacing Jul 14, 2022
@ggazzo ggazzo changed the title chore(fuselage): Add forwardRef to TopBarAction and SidebarAction to fix icon spacing chore(fuselage): Add forwardRef to TopBarAction and SidebarAction Jul 14, 2022
@ggazzo ggazzo merged commit add569d into develop Jul 14, 2022
@ggazzo ggazzo deleted the feat/sidebar-topbar-action-ref branch July 14, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants