New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Channelname slot based intents #26
Merged
Sing-Li
merged 32 commits into
RocketChat:master
from
AdarshNaidu:channelname-slot-based-intents
Aug 30, 2020
Merged
Channelname slot based intents #26
Sing-Li
merged 32 commits into
RocketChat:master
from
AdarshNaidu:channelname-slot-based-intents
Aug 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains intents that require channel name resolution before intent confirmation.
This PR contains the following intents:
Additional features in this PR
after executing an intent or after any error message.
These intents make use of the following intent generation functions:
handleConfirmationChannelResolution: This function generates an intent which handles confirmation for any operation that requires channel name resolution. The intent generated from this function responds with intent confirmation or an error message if any. It resolves channel name from the list of rooms that the user is part of before giving confirmation. This function also takes a function as one of the parameters which gets executed at the end. This makes this intent generator function flexible, as it can be modified according to different intents.
handleExecutionChannelResolution: This function is responsible for executing the operation if the user has confirmed the intent. This function also takes a function as parameter making it more flexible.