-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP router for hubot HealthCheck #48
Comments
This would be good to have in the SDK. It might be a requirement anyway for @mikaelmello's project to show status of all bots in an admin view. It can be achieved more easily in Hubot though, because it has an express server built in, so maybe use this issue to work on draft feature and proof of concept, then when it's functional and settled, we could migrate it into SDK? Would have to find some light-weight way of setting up a HTTP listener, because most bot frameworks include a server and I wouldn't want to double up by adding one to the SDK. |
Totally, in fact I think that once we do have a manager interface for bots, the server could use a ddp event to check if the bot is online and responding, maybe even collect some stats of usage, and then provide that information to a rocketchat server webhook or some REST API endpoint, so any external application could check and use that info to maintain, restart or kill the bot. For now I totally agree that we need to scratch this first, and Hubot's http router seems to be our best shot now. We can focus on designing the data object to be sent, and then just add other interface to retrieve it, maybe keep them both, the DDP event (could call it Just shooting some ideas here.. =P |
When the bot dies, we don't have any notification.
There are a few possible situations where a bot can die, an outage of the server can be one of those.
But the thing is that we need to check if the bot is alive and able to post messages into the server, and the best way to do this is enabling a http endpoint where we can send a GET request and receive some data back.
For that we have a good example in https://leanpub.com/automation-and-monitoring-with-hubot/read#leanpub-auto-serving-http-requests
We could use some inspiration from hubot-diagnostics but remembering that we need to have the bots health information through http requests, for infrastructure checking purposes.
/assign @arthurTemporim
The text was updated successfully, but these errors were encountered: