Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Additional poll modes #11

Merged
merged 14 commits into from Sep 14, 2021

Conversation

RonLek
Copy link
Collaborator

@RonLek RonLek commented Jul 31, 2021

  • Adds template slash subcommand for trigerring Poll creation through templates.
  • Creates Poll Template Modal with StaticSelectElement to select poll template.
  • Adds Overrated/Underrated Poll (Options: Overrated, Appropriately Rated, Never Tried, Underrated).
  • Adds 1-to-5 Poll (Options: 1 - 5)
  • Adds 1-to-10 Poll (Options: 1 - 10)
  • Adds Agree/Disagree Poll (Options - Agree, Disagree)
  • Adds Emoji Rank Poll (Options - 馃ぉ Great, 馃檪 Good, 馃槓 Neutral, 馃檨 Bad, 馃槩 Awful)
Screencast.from.31-07-21.07.32.07.PM.IST.mp4

Closes #10

@RonLek RonLek requested a review from ramkumarkb July 31, 2021 14:29
@RonLek
Copy link
Collaborator Author

RonLek commented Jul 31, 2021

@murtaza98 @ramkumarkb Please take a look. Thanks.

@RonLek
Copy link
Collaborator Author

RonLek commented Aug 8, 2021

@murtaza98 Modified the /poll template flow and used interactivity directly for modifying the existing modal. Please take a look.

Screencast.from.08-08-21.01.24.23.PM.IST.mp4

@murtaza98
Copy link

Getting this issue in this PR

@murtaza98
Copy link

murtaza98 commented Sep 12, 2021

Hi, @RonLek I'm still getting this issue on the latest code for this branch.

Issue:

  • start a poll in multiple-choice questions mode and enter more than 2 options
  • switch the mode to single-choice and notice only 2 options are visible. Ideally, it shouldn't hide any options. Please check out the below clip for more info.
options-state-not-being-maintained.mp4

@RonLek
Copy link
Collaborator Author

RonLek commented Sep 12, 2021

Thanks @murtaza98 . This one is still WIP.

@murtaza98
Copy link

Thanks @murtaza98. This one is still WIP.

Hey @RonLek, I've came up with this simple solution for this PR. Feel free to review and merge it into this PR, or if you wish to implement any other solution, that's fine as well.

@RonLek
Copy link
Collaborator Author

RonLek commented Sep 12, 2021

That's awesome! Thanks @murtaza98 . I've made a few fixes within your PR. Let me know if I can proceed with merging your updated PR within this branch.

@murtaza98
Copy link

Hi, @RonLek Thanks for the fixes. The changes look good. Feel free to merge it into your main PR 馃槂

[FIX] persist options state which changing modes
@RonLek
Copy link
Collaborator Author

RonLek commented Sep 13, 2021

Thanks @murtaza98 . Merged it in within this one.

@murtaza98
Copy link

Awesome Thanks!! This LGTM!!

@ramkumarkb ramkumarkb merged commit 5d09c17 into RocketChat:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Additional Poll Modes Template
3 participants