Hotfix/astro 1458 monitor icon fix #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markacianfrani
requested review from
Full-lifey,
dmcalester,
Cheshire89,
micahjones13 and
NicDominguez
dmcalester
approved these changes
Jun 1, 2021
Cheshire89
approved these changes
Jun 1, 2021
Cheshire89
reviewed
Jun 1, 2021
| @@ -84,7 +84,12 @@ export class RuxMonitoringProgressIcon extends RuxMonitoringIcon { | |||
|
|
|||
| get iconTemplate() { | |||
| return html` | |||
| <rux-icon icon="progress" class="rux-status--${this.status}"></rux-icon> | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128" style="" class="rux-status--${this.status}"> | |||
There was a problem hiding this comment.
why are you resorting to using the svg instad of the rux-icon component ?
There was a problem hiding this comment.
This is because we need a variable stroke length for the SVG depending on progress %.
Passing all of these svg attributes down through the icon component for this single edge case doesn't make sense.
There was a problem hiding this comment.
5.1 removed the progress icon entirely. Because it's a one off, I just inlined the svg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
ASTRO-1458
New bug I just discovered where the progress was rendering 100% if the threshold was set to 100.
Breaking Change:
Icon size was changed to 44px, instead of 43.19. This is to fix a consistency issue involving rux-icon. The readme for rux-icon lists: 'supported values are extra-small (16px), small (32px), normal (44px) and large (64px)'.
Description:
5.1 removed the progress icon entirely. Because it's a one off, I just inlined the svg. Because I'm no longer using the rux-icon component, the colors weren't working so shortest, fastest solution was to just copy them back in from rux-monitoring-icon scoped under the new svg element.
We can use the stencil rewrite to refactor a lot of this. This fixes the issue and provides with a base for our regression tests.