Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/fix readme link #141

Merged
merged 1 commit into from
Jun 15, 2021
Merged

hotfix/fix readme link #141

merged 1 commit into from
Jun 15, 2021

Conversation

NicDominguez
Copy link
Contributor

The link to the component library in the readme template and subsequently all component readme files was https://github.com/RocketCommunicationsInc/astro-components/src/master/ which lead to a 404 error. This fix updates that link to https://github.com/RocketCommunicationsInc/astro-components/

Copy link
Contributor

@dmcalester dmcalester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, most of these changes reflect updates from Prettier?

@NicDominguez
Copy link
Contributor Author

Yes, prettier ran on my local copy, but the substantive change is to the link url to the github repo. I'll have to turn off the auto formatting on my Prettier extension.

@dmcalester dmcalester self-requested a review June 15, 2021 16:01
@NicDominguez NicDominguez merged commit 6163185 into next Jun 15, 2021
@nortonprojects nortonprojects deleted the hotfix/fix-readme-link branch June 15, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants