Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array pokemonWithImages should be defined only once. #2358

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Array pokemonWithImages should be defined only once. #2358

merged 1 commit into from
Nov 1, 2017

Conversation

sLoPPydrive
Copy link
Contributor

Description

The array of Pokemon IDs used in raids was defined in two places (and had to be edited in two places as well). One place should be enough. ;-)

Motivation and Context

Removes code redundancy. Easier to maintain.

How Has This Been Tested?

By running a local map.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@pogo-excalibur
Copy link
Contributor

I think this is a great change, but it's going to be superceeded by #2348 which will completely rework how images are matched to Pokemon.

@sebastienvercammen
Copy link
Member

@pogo-excalibur Agreed that it'll be unnecessary soon, but until then this is a very minor change.

@sebastienvercammen sebastienvercammen merged commit dbd377c into RocketMap:develop Nov 1, 2017
@sLoPPydrive sLoPPydrive deleted the P-PokemonWithImages branch November 3, 2017 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants