Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for new raid bosses #2367

Merged
merged 2 commits into from
Nov 6, 2017
Merged

Added support for new raid bosses #2367

merged 2 commits into from
Nov 6, 2017

Conversation

sirlindqvist
Copy link
Contributor

@sirlindqvist sirlindqvist commented Nov 5, 2017

Added support for the new raid bosses appearing in the game.

Description

Added support for the new raid bosses appearing in the game. Didn't remove the old ones in the code since no-one knows if they will pop again or not. Hopefully this is the last time a PR of this kind will be made since #2348 will change how we handle icons in RocketMap.

Motivation and Context

How Has This Been Tested?

Local map.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

static/js/map.js Outdated
@@ -73,8 +73,8 @@ const cryFileTypes = ['wav', 'mp3']
const genderType = ['♂', '♀', '⚲']
const unownForm = ['unset', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z', '!', '?']
const pokemonWithImages = [
3, 6, 9, 59, 65, 68, 89, 94, 103, 110, 112, 125, 126, 129, 131, 134,
135, 136, 143, 144, 145, 146, 150, 153, 156, 159, 243, 244, 245, 248, 249
2, 3, 5, 6, 8, 9, 11, 28, 31, 34, 38, 59, 62, 65, 68, 71, 73, 76, 89, 91, 94, 103, 105, 110, 112, 123, 125, 126, 129, 131, 134,
Copy link
Contributor

@KartulUdus KartulUdus Nov 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're missing 82 (Magneton) 😱

250 🤔 is Ho-oh out yet?

@SkOODaT
Copy link

SkOODaT commented Nov 5, 2017

why dont we just add everything and be done with it, niantic is gonna rotate this more then likely...

@Alderon86
Copy link
Contributor

Alderon86 commented Nov 5, 2017

@SkOODaT because that would mean we need to generate a shitton of images. #2348 is wip to solve that

Copy link
Member

@FrostTheFox FrostTheFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zip structure is proper.

@sebastienvercammen sebastienvercammen merged commit 5bd6291 into RocketMap:develop Nov 6, 2017
billyj85 pushed a commit to billyj85/RocketMap that referenced this pull request Dec 8, 2017
* Added support for new raid bosses

* Fix ID82 missing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants