Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes related to Commands might be a breaking change #57

Closed
sunnamed434 opened this issue May 12, 2024 · 2 comments · Fixed by #59
Closed

Changes related to Commands might be a breaking change #57

sunnamed434 opened this issue May 12, 2024 · 2 comments · Fixed by #59
Labels
bug Something isn't working

Comments

@sunnamed434
Copy link

(Report by @GazziFX) PR #48 can be a breaking change because Commands property can be a breaking change.

If he's right I'd suggest reverting changes from #48 PR
@sunnamed434 sunnamed434 added the bug Something isn't working label May 12, 2024
sunnamed434 added a commit that referenced this issue May 12, 2024
@sunnamed434
Rollback RocketCommandManager changes (fix #57)
f036bee
@sunnamed434 sunnamed434 linked a pull request May 12, 2024 that will close this issue
Rollback RocketCommandManager changes (fix #57) #59
Merged
sunnamed434 added a commit that referenced this issue May 13, 2024
@sunnamed434
Merge pull request #59 from RocketModFix/fix/#57
de0ac20 
Rollback RocketCommandManager changes (fix #57)
@GazziFX
Copy link

GazziFX commented May 13, 2024

Maybe support both dictionary and list as fallback?

@sunnamed434
Copy link
Author

Idk if it even makes sense to have a dictionary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rollback RocketCommandManager changes (fix #57) RocketModFix/RocketModFix
2 participants
@GazziFX @sunnamed434