Fix UnturnedPlayerComponent not being added automatically

README.md

@@ -30,7 +30,7 @@ You can still use old RocketMod plugins without any changes/recompilation/update
 		- [ ] OpenMod.
 - [ ] RocketMod Fixes:
 	- [ ] Fix UnturnedPlayer.SteamProfile (cause so many lags). 
-	- [ ] Fix UnturnedPlayerComponent is not being added automatically.
+	- [x] Fix UnturnedPlayerComponent is not being added and removed automatically.
 	- [ ] Assembly Resolve fixes (don't spam with not found library or make a option to disable it, load all libraries at rocketmod start instead of searching for them only on OnAssemblyResolve)
 	- [ ] Commands fixes:
 		- [ ] Fix /vanish.

Rocket.Unturned/Plugins/PluginUnturnedPlayerComponentManager.cs

@@ -17,51 +17,64 @@ public sealed class PluginUnturnedPlayerComponentManager : MonoBehaviour
     {
         private Assembly assembly;
         private List<Type> unturnedPlayerComponents = new List<Type>();
-        
+
         private void OnDisable()
         {
             try
             {
                 U.Events.OnPlayerConnected -= addPlayerComponents;
                 unturnedPlayerComponents = unturnedPlayerComponents.Where(p => p.Assembly != assembly).ToList();
                 List<Type> playerComponents = RocketHelper.GetTypesFromParentClass(assembly, typeof(UnturnedPlayerComponent));
-                foreach (Type playerComponent in playerComponents)
+                for (var i = 0; i < playerComponents.Count; i++)
                 {
-                    //Provider.Players.ForEach(p => p.Player.gameObject.TryRemoveComponent(playerComponent.GetType()));
+                    var playerComponent = playerComponents[i];
+                    var clients = Provider.clients;
+                    for (var j = 0; j < clients.Count; j++)
+                    {
+                        var steamPlayer = clients[j];
+                        steamPlayer.player.gameObject.TryRemoveComponent(playerComponent.GetType());
+                    }
                 }
             }
             catch (Exception ex)
             {
-                Core.Logging.Logger.LogException(ex);
+                Core.Logging.Logger.LogException(ex, $"An error occured while removing {nameof(UnturnedPlayerComponent)}");
             }
         }
 
         private void OnEnable()
         {
             try
-            {  
+            {
                 IRocketPlugin plugin = GetComponent<IRocketPlugin>();
                 assembly = plugin.GetType().Assembly;
 
                 U.Events.OnBeforePlayerConnected += addPlayerComponents;
                 unturnedPlayerComponents.AddRange(RocketHelper.GetTypesFromParentClass(assembly, typeof(UnturnedPlayerComponent)));
 
-                foreach (Type playerComponent in unturnedPlayerComponents)
+                for (var i = 0; i < unturnedPlayerComponents.Count; i++)
                 {
-                    Core.Logging.Logger.Log("Adding UnturnedPlayerComponent: "+playerComponent.Name);
-                    //Provider.Players.ForEach(p => p.Player.gameObject.TryAddComponent(playerComponent.GetType()));
+                    var playerComponent = unturnedPlayerComponents[i];
+                    Core.Logging.Logger.Log("Adding UnturnedPlayerComponent: " + playerComponent.Name);
+                    var clients = Provider.clients;
+                    for (var j = 0; j < clients.Count; j++)
+                    {
+                        var steamPlayer = clients[j];
+                        steamPlayer.player.gameObject.TryAddComponent(playerComponent.GetType());
+                    }
                 }
             }
             catch (Exception ex)
             {
-                Core.Logging.Logger.LogException(ex);
+                Core.Logging.Logger.LogException(ex, $"An error occured while adding {nameof(UnturnedPlayerComponent)}");
             }
         }
 
         private void addPlayerComponents(IRocketPlayer p)
         {
-            foreach (Type component in unturnedPlayerComponents)
+            for (int i = 0; i < unturnedPlayerComponents.Count; i++)
             {
+                var component = unturnedPlayerComponents[i];
                 ((UnturnedPlayer)p).Player.gameObject.AddComponent(component);
             }
         }