Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Environment Analysis - Wind Rose Improvements #191

Conversation

giovaniceotto
Copy link
Member

@giovaniceotto giovaniceotto commented Jun 17, 2022

Pull request type

Please check the type of change your PR introduces:

  • Code base additions (bugfix, features)
  • Code maintenance (refactoring, formatting, renaming, tests)
  • ReadMe, Docs and GitHub maintenance
  • Other (please describe):

Pull request checklist

Please check if your PR fulfills the following requirements, depending on the type of PR:

  • Code base maintenance (refactoring, formatting, renaming):

    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally
  • Code base additions (for bug fixes / features):

    • Tests for the changes have been added
    • Docs have been reviewed and added / updated if needed
    • Lint (black rocketpy) has passed locally and any fixes were made
    • All tests (pytest --runslow) have passed locally

What is the current behavior?

  • It is unknown if wind roses are displaying wind heading or wind direction.
  • Wind speed divisions do not follow a standard, such as the Beaufort standard.

What is the new behavior?

  • Wind roses now use wind direction, which specifies where the wind blows from. This is clearly stated in the example notebook.
  • Wind roses use the Beaufort wind force scale, giving a more sensible dimension to wind speeds.
  • A more detailed description of wind roses has been added to the example notebook.

Does this introduce a breaking change?

  • Yes
  • No

@giovaniceotto giovaniceotto changed the base branch from master to enh/environment_analysis June 17, 2022 03:38
@giovaniceotto giovaniceotto added this to the Environment Analysis milestone Jun 17, 2022
@giovaniceotto giovaniceotto self-assigned this Jun 17, 2022
@giovaniceotto giovaniceotto added the Enhancement New feature or request, including adjustments in current codes label Jun 17, 2022
@giovaniceotto giovaniceotto marked this pull request as ready for review June 18, 2022 23:43
@giovaniceotto
Copy link
Member Author

Final Result

image

wind_rose

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@giovaniceotto giovaniceotto merged commit 712b063 into enh/environment_analysis Jun 21, 2022
@Gui-FernandesBR Gui-FernandesBR deleted the enh/environment_analysis_wind_rose_improvements branch September 10, 2022 12:10
@Gui-FernandesBR Gui-FernandesBR added the Environment Enviroment Class related features label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request, including adjustments in current codes Environment Enviroment Class related features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants