-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Support for Hybrid Motors part 1 #198
Conversation
The reference point for the calculation of the center of mass of the motor was altered from the geometric center of the propellant grain to the nozzle
distanceNozzlePropellant was changed for distanceNozzleMotorReference. The variables were adjusted in the notebooks.
ENH: change of variables between rocket and motor
A method was added that allows calculating the variation of the center of mass of the hybrid motor using a linear interpolation.
Heyy! Think I maneged to solve all he conflicts and fix all the tests!! Only thing missing here is a test for a thrust source given by a .rse file. @ompro07 could you create a simple test using a .rse file? Besides that I think this one is done. Will only be missing a classic @giovaniceotto review |
I am currently working on this review. It is quite a long PR and, unfortunately, it's been a while since I first read the code. It should take a couple of days for me to finish. My intention is to finish by, at most, Friday. |
I recommend you to read the other pull requestd we have made untill to get at this point. Indeed it's a large PR, but if you take it step by step you're going to see there's no Rocket science here. The most difficult part I think is related to distances vs positions |
@PatrickSampaioUSP is also set as reviewer to test if the code is working! We need to proceed with this one too. |
@Gui-FernandesBR what about those conflicts? Usually you have to resolve the conflicts before the code review (merge the master branch into this branch, resolve the conflicts, then commit to this branch). |
Thanks @MateusStano for solving the merge conflicts. I'll continue my review. |
I read the changes, and I understood that those are some features that we want to publish in order to have a functional Motor class for some basic features of the Hybrid. However there are some aspects of the implementation that worries me:
|
Task linked: CU-864dp0fng Hybrid Motors |
Replaced by #233 |
Pull request type
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
Code base additions (for bug fixes / features):
black rocketpy
) has passed locally and any fixes were madepytest --runslow
) have passed locallyWhat is the current behavior?
RocketPy currerntly does not support Hybrid motor, which is such a limitation for our project right now. Therefore @ompro07 and @MrGribel commited theirselves to work on the different approaches to implement the non-soldid motors. However, the roadtrip seems to be more difficult than what we expected, and right now we are pulling simple features that will allow further enhancements.
What is the new behavior?
In this PR we submitting the following aditions:
Also, we adjusted all tests files to accomplish with those changes!! Hope it facilitates the final review.
Does this introduce a breaking change?
Other information
This is a 1st part of 2 different developments, The next steps will be started on next months and should include at least the following developments: