FIX: fixing docs errors #202
Conversation
|
@PatrickSampaioUSP tkns for helping, We need address pytests failure before merging, it seems there's a problem on Also, shouldn't be better merging into develop branch before master so we guarantee they before stay syncronized ? |
|
Usually we should merge hot_fixes directly to the master, and then after we update the develop branch |
There was a problem hiding this comment.
Since all relevant changes are done in the docs folder, I am confortable merging it directly to the master branch to fix such docs issue.
Furthermore, the changes made outside the docs folder are small and simple to review.
I am approving this PR and merging it.
| @@ -22,6 +22,7 @@ | |||
| __status__ = "Production" | |||
|
|
|||
| from .Environment import Environment | |||
| from .EnvironmentAnalysis import EnvironmentAnalysis | |||
There was a problem hiding this comment.
Does this addition mean we might have bugs with the currently release when importing EnvironmentAnalsyis? @PatrickSampaioUSP
I guess my question is, does from rocketpy import * also import EnvironmentAnalysis just as from rocketpy import EnvironmentAnalysis does?
There was a problem hiding this comment.
Yes, that would be a problem?
|
@PatrickSampaioUSP @giovaniceotto need some extra help here, apperantly the documentation is still failling, do you know how to solve this ?
|
|
|
|
Yeah, by some bizarre reason he is not finding the timezonefinder>=6.0.2 |
Ok so how can we fix that? Unfortunately there's no possiblity of re-opening te pull request, but as long we don't have restored documentation page completely, our job is not done. In the screen shot you presented above, it seems timezonefinder requires a specifically different python version. Since we only use this on the Environment Analysis file, shall we remove timezone from requirements and stop using it from rocketpy package until we discover other solution for the |
No description provided.