Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: EmptyMotor is breaking the Rocket.draw() method #516

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

Gui-FernandesBR
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR commented Dec 19, 2023

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)(not needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

Try to call the Rocket.draw() method without adding a motor to the rocket. The EmptyMotor will be used as default, the plot will be created but an error will also be displayed
image

New behavior

Changed the order of some operations and solved the problem.

Breaking change

  • No

Additional information

Bug reported from UPV-Faraday rocketry team (Valencia, Spain).

@Gui-FernandesBR Gui-FernandesBR added the Bug Something isn't working label Dec 19, 2023
@Gui-FernandesBR Gui-FernandesBR changed the title FIX: EmptyMotor is breaking the Rocket.draw() method BUG: EmptyMotor is breaking the Rocket.draw() method Dec 19, 2023
@Gui-FernandesBR Gui-FernandesBR added this to the Release v1.X.0 milestone Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (7eb4a73) 71.16% compared to head (f1367e3) 71.30%.
Report is 22 commits behind head on develop.

Files Patch % Lines
rocketpy/simulation/flight_data_importer.py 83.33% 15 Missing ⚠️
rocketpy/units.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #516      +/-   ##
===========================================
+ Coverage    71.16%   71.30%   +0.14%     
===========================================
  Files           55       56       +1     
  Lines         9279     9374      +95     
===========================================
+ Hits          6603     6684      +81     
- Misses        2676     2690      +14     
Flag Coverage Δ
unittests 71.30% <80.73%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR merged commit 476872f into develop Dec 19, 2023
13 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the bug/empty-motor-draw branch December 19, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants