BUG: EmptyMotor is breaking the Rocket.draw() method #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/
) has passed locallypytest --runslow
) have passed locallyCHANGELOG.md
has been updated (if relevant)Current behavior
Try to call the Rocket.draw() method without adding a motor to the rocket. The EmptyMotor will be used as default, the plot will be created but an error will also be displayed
![image](https://private-user-images.githubusercontent.com/63590233/291509501-87a6b6ce-0fe9-4e30-824a-04f28875b3ba.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk0MjQ2MDMsIm5iZiI6MTcxOTQyNDMwMywicGF0aCI6Ii82MzU5MDIzMy8yOTE1MDk1MDEtODdhNmI2Y2UtMGZlOS00ZTMwLTgyNGEtMDRmMjg4NzViM2JhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI2VDE3NTE0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJkMWFiNzgxZDNjMGRmNjYyYjUzYjk4ODNiY2FlNWFiYTk1MmQ5M2NmZjc4MTI2OTg0Y2FjNzVjN2ZhNTljYzYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0_UKHPIPcH6EB6QhKnU7LKdvLXKCVBSEjQdqhLo7XOs)
New behavior
Changed the order of some operations and solved the problem.
Breaking change
Additional information
Bug reported from UPV-Faraday rocketry team (Valencia, Spain).