Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: pyproject.toml Main Module Finding. #616

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

phmbressan
Copy link
Collaborator

Pull request type

  • Other (please describe): Release install fix

Checklist

  • CHANGELOG.md has been updated (if relevant)

Current behavior

There is an issue with package discovery in current build with pyproject.toml.

New behavior

This PR allows for the discovery of rocketpy main package and its submodules.

Breaking change

  • Yes
  • No

@phmbressan phmbressan added Bug Something isn't working Releases Related with new releases labels Jun 2, 2024
@phmbressan phmbressan added this to the Release v1.X.0 milestone Jun 2, 2024
@phmbressan phmbressan self-assigned this Jun 2, 2024
@phmbressan phmbressan requested a review from a team as a code owner June 2, 2024 17:33
Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.65%. Comparing base (3629e86) to head (cd14018).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   73.60%   73.65%   +0.04%     
==========================================
  Files          70       70              
  Lines       10289    10289              
==========================================
+ Hits         7573     7578       +5     
+ Misses       2716     2711       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Python 3.10.11 running on windows 11 and it worked quite well.

python -m venv .venv


pip install -e .[all]
pip install -r requirements-tests.txt
pytest

@phmbressan phmbressan merged commit 54c69a3 into master Jun 3, 2024
10 checks passed
@phmbressan phmbressan deleted the rel/v1.3.0.post1 branch June 3, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Releases Related with new releases
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants