Merge pull request #13 from RocketSurgeonsGuild/feature/download-pack…

…age-icon Feature/download package icon
RocketSurgeonsGuild · Sep 23, 2019 · 747e54c · 747e54c
2 parents 3e1da08 + fb8166a
commit 747e54c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Packages.props b/Packages.props
@@ -13,7 +13,7 @@
     <PackageReference Update="Buildalyzer" Version="2.3.0" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Update="Rocket.Surgery.Extensions.Testing.FakeItEasy" Version="2.0.0-beta.66" />
+    <PackageReference Update="Rocket.Surgery.Extensions.Testing.FakeItEasy" Version="2.0.0" />
     <PackageReference Update="Autofac.Extras.FakeItEasy" Version="5.0.1" />
     <PackageReference Update="Bogus" Version="28.2.1" />
     <PackageReference Update="coverlet.collector" Version="1.0.1" />

diff --git a/src/Nuke/DownloadFileAttribute.cs b/src/Nuke/DownloadFileAttribute.cs
@@ -29,11 +29,11 @@ public class DownloadFileAttribute : Attribute, IOnAfterLogo
         /// Ensures that the icon at the given url is downloaded into the specified filePath
         /// </summary>
         /// <param name="url">The Url to download</param>
-        /// <param name="filePath">The file path to download to, defaults to TemporaryDirectory / packageicon.[ext]</param>
+        /// <param name="filePath">The file path to download to inside the temporary directory</param>
         public DownloadFileAttribute(string url, string filePath)
         {
             _url = url ?? throw new ArgumentNullException(nameof(url));
-            _filePath = filePath == null ? throw new ArgumentNullException(nameof(filePath)) : (AbsolutePath)filePath;
+            _filePath = filePath == null ? throw new ArgumentNullException(nameof(filePath)) : NukeBuild.TemporaryDirectory / filePath;
         }
 
         /// <inheritdoc />

diff --git a/src/Nuke/PackageIconAttribute.cs b/src/Nuke/PackageIconAttribute.cs
@@ -18,7 +18,7 @@ public sealed class PackageIconAttribute : DownloadFileAttribute
         /// <param name="url">The Url to download</param>
         /// <param name="filePath">The file path to download to, defaults to TemporaryDirectory / packageicon.[ext]</param>
         public PackageIconAttribute(string url, string filePath = null)
-            : base(url, filePath == null ? NukeBuild.TemporaryDirectory / ("packageicon" + System.IO.Path.GetExtension(url)) : (AbsolutePath)filePath)
+            : base(url, filePath == null ? ("packageicon" + System.IO.Path.GetExtension(url)) : (AbsolutePath)filePath)
         {
             Type = "Package Icon";
         }