Upgrade to Clerk Core 2 #2
Conversation
|
Thanks for the updates! Will wait for the ready for review :) |
src/module.ts
Outdated
| getContents: () => [ | ||
| 'export default {', | ||
| ` vueClerkConfig: ${options.vueClerk ? JSON.stringify(options.vueClerk) : 'null'}`, | ||
| ` vueClerkOptions: ${options.vueClerk ? JSON.stringify(options.vueClerk) : 'null'},`, | ||
| ` h3ClerkOptions: ${options.vueClerk ? JSON.stringify(options.h3Clerk) : 'null'},`, |
There was a problem hiding this comment.
I assume this will not be included in client build?
| getContents: () => [ | ||
| 'export default {', | ||
| ` vueClerkConfig: ${options.vueClerk ? JSON.stringify(options.vueClerk) : 'null'}`, | ||
| ` vueClerkOptions: ${options.vueClerk ? JSON.stringify(options.vueClerk) : 'null'},`, | ||
| ` h3ClerkOptions: ${options.h3Clerk ? JSON.stringify(options.h3Clerk) : 'null'},`, |
There was a problem hiding this comment.
I assume this will not be included in client bundle 👀
There was a problem hiding this comment.
It all depends on where it is imported! Let me check
There was a problem hiding this comment.
We should create a server and client plugin and only import the template of the config we need in each enviroment.
Which means creating 2 templates, one for the client config and another for the server config if it makes sense
There was a problem hiding this comment.
@RodrigoProjects would you be interested in doing that?
|
@RodrigoProjects pushed more updates that will upgrade this to Clerk Core 2. |
pnpm-lock.yaml
Outdated
There was a problem hiding this comment.
We have a bun lockfile so I believe this is extra
| "h3-clerk": "^0.3.8", | ||
| "vue-clerk": "^0.1.1" | ||
| "@nuxt/kit": "^3.12.1", | ||
| "@nuxtjs/tailwindcss": "^6.12.0", |
There was a problem hiding this comment.
#4 - I agree with this. Do we really need tailwind as dep?
Hi! Appreciate you doing this module.
This PR updates vue-clerk and h3-clerk versions, fix incorrect imports and updated the playground.
Update: This PR now upgrades the h3-clerk and vue-clerk to Clerk Core 2 versions