Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export platform_interface #286

Merged

Conversation

jamieastley
Copy link
Contributor

What this does

  • exports flutter_branch_sdk_platform_interface so as to consume from outside this package

Why this is required

  • As per the plugin_platform_interface docs, exporting this class allows users of this package to fake/mock the Branch SDK instance in tests and validate their own business logic.

@jamieastley
Copy link
Contributor Author

Apologies, just realised this is to merge to master, but not sure if dev would be preferred given there's no CONTRIBUTING.md defined.

Let me know which is preferred and I'll update accordingly.

@RodrigoSMarques
Copy link
Owner

Hi @jamieastley
You can keep it in the master branch.

I will merge soon and release a new version

@RodrigoSMarques RodrigoSMarques changed the base branch from master to dev January 27, 2024 13:25
@RodrigoSMarques RodrigoSMarques merged commit b904047 into RodrigoSMarques:dev Jan 27, 2024
2 checks passed
@jamieastley jamieastley deleted the fix/export-platform-interface branch February 1, 2024 04:58
RodrigoSMarques added a commit that referenced this pull request Feb 1, 2024
### Issues

* Fix issue #277 : PlatformException - NullPointerException

### Features
* PR #286 : fix: export platform_interface
* Updated configuration steps in README.MD
* Sample app - code review
@RodrigoSMarques RodrigoSMarques mentioned this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants