Remove unnecessary OS dependencies adding resvg as build-dependencies #9
+357
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the contribution! It's a great change; I should have implemented it this way from the start. And from your android screenshot I see that you have the same issue as in #8. I need to take a look at that. @samuel-cavalcanti Vlw! |
Rodrigodd
added a commit
that referenced
this pull request
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, current this project needs to install resvg in the OS, But it's possible to create the png files adding
resvgas build-dependencies. Basically this pull request will replace the sub commands.Btw I use Archlinux, so I tested it in linux and android:
Aproposito @Rodrigodd muito bom trabalho ta de parabéns !!! 👌 👏 👏