Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Se añade metodos equals a Coordenda, Consecuencia, Celda, Camino y Ma… #143

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

RodriguezNazareno56
Copy link
Owner

…pa para poder comparar dos instancias de dichas entidades. Con esto se logra refactorizar los test de casos de uso 15, 16 y 17 que ya no corraboran la correcta creacion del camino, mapa o juego, moviendo un gladiador a lo largo del mismo, esperando que se afecte de un modo consistente con el Json, sino que simplemente se comparan la instancia obtenida al cargar el json con una instancia hardcodeada consistente con el json

…pa para poder comparar dos instancias de dichas entidades. Con esto se logra refactorizar los test de casos de uso 15, 16 y 17 que ya no corraboran la correcta creacion del camino, mapa o juego, moviendo un gladiador a lo largo del mismo, esperando que se afecte de un modo consistente con el Json, sino que simplemente se comparan la instancia obtenida al cargar el json con una instancia hardcodeada consistente con el json
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (d6fc062) 89.38% compared to head (50eb109) 85.41%.

Files Patch % Lines
...rc/main/java/edu/fiuba/algo3/modelo/mapa/Mapa.java 16.66% 1 Missing and 4 partials ⚠️
...ain/java/edu/fiuba/algo3/modelo/camino/Camino.java 40.00% 1 Missing and 2 partials ⚠️
.../java/edu/fiuba/algo3/modelo/celda/Coordenada.java 40.00% 1 Missing and 2 partials ⚠️
...fiuba/algo3/modelo/consecuencias/Consecuencia.java 50.00% 1 Missing and 2 partials ⚠️
.../main/java/edu/fiuba/algo3/modelo/celda/Celda.java 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #143      +/-   ##
============================================
- Coverage     89.38%   85.41%   -3.97%     
- Complexity      190      197       +7     
============================================
  Files            47       48       +1     
  Lines           452      480      +28     
  Branches         16       26      +10     
============================================
+ Hits            404      410       +6     
- Misses           43       54      +11     
- Partials          5       16      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RodriguezNazareno56 RodriguezNazareno56 merged commit 56f8ea0 into master Dec 1, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant