Add permission granularity for ToDO Tasks

#131

custom_components/o365/classes/taskssensor.py

@@ -43,10 +43,13 @@ def __init__(
         super().__init__(coordinator, name, entity_id, SENSOR_TODO, unique_id)
         self.todo = todo
         self._show_completed = show_completed
-        if show_completed:
-            self.query = self.todo.new_query("status")
-        else:
-            self.query = self.todo.new_query("status").unequal("completed")
+        self.query = self.todo.new_query()
+        if not show_completed:
+            self.query = self.query.on_attribute("status").unequal("completed")
+
+        # self.query.chain("and").on_attribute("duedatetime").less_equal(
+        #     datetime.now(timezone.utc)
+        # )
         self._config = config
         self.task_last_created = dt.utcnow() - timedelta(minutes=5)
         self.task_last_completed = dt.utcnow() - timedelta(minutes=5)

custom_components/o365/schema.py

@@ -10,9 +10,11 @@
 )
 from homeassistant.const import CONF_ENABLED, CONF_NAME
 
-from O365.calendar import AttendeeType  # pylint: disable=no-name-in-module
-from O365.calendar import EventSensitivity  # pylint: disable=no-name-in-module
-from O365.calendar import EventShowAs  # pylint: disable=no-name-in-module
+from O365.calendar import (
+    AttendeeType,  # pylint: disable=no-name-in-module
+    EventSensitivity,  # pylint: disable=no-name-in-module
+    EventShowAs,  # pylint: disable=no-name-in-module
+)
 from O365.mailbox import ExternalAudience  # pylint: disable=no-name-in-module
 from O365.utils import ImportanceLevel  # pylint: disable=no-name-in-module
 
@@ -132,6 +134,7 @@
     {
         vol.Required(CONF_ENABLED, default=False): bool,
         vol.Optional(CONF_TRACK_NEW, default=True): bool,
+        vol.Optional(CONF_ENABLE_UPDATE, default=False): bool,
     }
 )
 

custom_components/o365/sensor.py

@@ -498,11 +498,12 @@ async def _async_setup_register_services(hass, config):
 
 
 async def _async_setup_task_services(hass, config):
-    if not config.get(CONF_ENABLE_UPDATE):
-        return
-
     todo_sensors = config.get(CONF_TODO_SENSORS)
-    if not todo_sensors or not todo_sensors.get(CONF_ENABLED):
+    if (
+        not todo_sensors
+        or not todo_sensors.get(CONF_ENABLED)
+        or not todo_sensors.get(CONF_ENABLE_UPDATE)
+    ):
         return
 
     sensor_services = SensorServices(hass)

custom_components/o365/utils.py

@@ -156,7 +156,7 @@ def build_requested_permissions(config):
     if len(chat_sensors) > 0:
         scope.append(PERM_CHAT_READ)
     if todo_sensors and todo_sensors.get(CONF_ENABLED, False):
-        if enable_update:
+        if todo_sensors[CONF_ENABLE_UPDATE]:
             scope.append(PERM_TASKS_READWRITE)
         else:
             scope.append(PERM_TASKS_READ)

docs/installation_and_configuration.md

@@ -34,7 +34,7 @@ o365:
       client_id: "xxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxx"
       client_secret: "xx.xxxxxxxxxxxxxxxxxxxxxxxxxxxx"
       alt_auth_method: False
-      enable_update: True
+      enable_update: False
       email_sensor:
         - name: inbox
           max_items: 2
@@ -163,6 +163,7 @@ Key | Type | Required | Description
 Key | Type | Required | Description
 -- | -- | -- | --
 `enabled` | `boolean` | `True` | True=Enables To-Do sensors, **False**=Disables To-Do sensors.
+`enable_update` | `boolean` | `False` | If True (**default is False**), this will enable the services to create/update/delete tasks
 
 #### auto_reply_sensors 
 

docs/permissions.md

@@ -14,7 +14,7 @@ Under "API Permissions" click Add a permission, then Microsoft Graph, then Deleg
   * Group Calendar - For a manually added Group calendar
   * AutoReply - For Auto reply/Out of Office message configuration
 
-  If you intend to use update functionality, then set [enable_update](./installation_and_configuration.md#configuration_variables) to `true`. Then for any sensor type, add the relevant `ReadWrite` permission as denoted by a `Y` in the update column.
+  If you intend to send emails use calendar update functionality, then set [enable_update](./installation_and_configuration.md#configuration_variables) at the top level to `true`. For Todo sensors set [enable_update](installation_and_configuration.md#todo_sensors) to true. Then for any sensor type, add the relevant `ReadWrite` permission as denoted by a `Y` in the update column.
 
 
    | Feature  | Permissions           | Update | O365 Description                      | Notes |