Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to create "loader apps" for use on Main Menu #336

Merged
merged 5 commits into from Sep 21, 2022

Conversation

ESurge
Copy link

@ESurge ESurge commented Sep 21, 2022

What's new

Loader App

  • It's a dummy app created for the purpose of attaching an application.fam file to use with Main Menu.
  • I added a link variable to the application.fam file. It's used to specify the FAP file location needed for loading

Loader.c

  • Changed loader.c to incorporate the application.fam link variable change which lets any FAP be on the Main Menu with the use of a "loader app"
  • This removes the hard coded app loading (Clock/iButton/U2F) and creates it dynamically

Note

  • If no link variable is specified in application.fam, it's automatically set to NULL which is then ignored by loader.c when launching the app.

Verification

  • Create a dummy app using clock_loader, ibutton_loader, or u2f_loader as an example.
  • Ensure the proper application.fam details are filled in, with the location of the FAP file needed for loading.
  • Ensure loader_app is included in Main/applications.fam file
  • Build
  • Test if app shows up on Main Menu and loads FAP correctly.
  • Also test if other apps still work correctly.

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Added a new variable in application.fam file to add the link to the FAP. It now supports any FAP as long as the application.fam file is formatted correctly and you create a loader "app".

If no link is specified in the application.fam file, it doesn't attempt to load a FAP.
@RogueMaster RogueMaster merged commit 48f0ad5 into RogueMaster:420 Sep 21, 2022
@RogueMaster
Copy link
Owner

Thank you, that is a lot less code than before and this will let us set as Favorites 😄

RogueMaster pushed a commit that referenced this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants