Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finally the Actual Working Pull Request (SORRY!) #360

Merged
merged 5 commits into from
Oct 14, 2022
Merged

Finally the Actual Working Pull Request (SORRY!) #360

merged 5 commits into from
Oct 14, 2022

Conversation

skizzophrenic
Copy link

What's new

Removed the Left Icon bar and removed the shadow on battery icon

Verification

  • [ Describe how to verify changes ]

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@RogueMaster
Copy link
Owner

Did you update the animations again or are these updates pushing the old animation?

@skizzophrenic
Copy link
Author

They're the updated animations, I'm not sure why it looks like its pushing again. I think you may have updated the animations right after I made the fork

@skizzophrenic
Copy link
Author

I also just added a Tuning Fork app that was uploaded to main apps channel. Removed the old Chip8 folder because it was causing compiling issues and it's broken/not updated in 10 months.

@RogueMaster
Copy link
Owner

I had already updated the animations recently, are these new updates (revision 3) or are these the wrong ones (revision 1)? Try to keep different features as different Pull Requests, makes for several branches to manage but easier to accept certain changes... I already added the gui changes so the only new item is the tuning fork app I think.

@skizzophrenic
Copy link
Author

the animations on this pull request are correct. I don't know what was up with the last one. This PR was supposed to just be the new tuning fork and removing the broken chip8 application that was causing compiling errors

@RogueMaster RogueMaster merged commit 64ee6eb into RogueMaster:420 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants