Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Fixed issues when loading iButton keys or U2F token from Archive app #382

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

ESurge
Copy link

@ESurge ESurge commented Oct 26, 2022

What's new

  • Fixed an issue when loading iButton keys from Archive app either as a pinned Favorite or selecting a file in the iButton section.
  • Fixed an issue when loading U2F token from Archive app either as a pinned Favorite or selecting a file in the U2F section.

Verification

Test 1 - iButton key select from iButton section:

  • Open Archive app
  • Select a key file from iButton section
  • Select Run in App
  • iButton FAP should load, and selected key file should automatically be running

Test 2 - iButton key select from Favorites section:

  • Open Archive app
  • Select a key file from iButton section
  • Select Pin
  • Close and reopen Archive app
  • Select iButton key file from Favorites section
  • iButton FAP should load, and selected key file should automatically be running

Notes

  • Verification steps can be repeated to test U2F token but I don't have a valid token to test at the moment

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants