Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation and source URL about the AM_Q CC1101 preset #995

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

user890104
Copy link

What's new

  • Added documentation about the AM_Q CC1101 preset. It originally came from Korai-Labs@79d67e4 on 2023-10-02, but with no documentation on what each register does and how this change improves RX/TX. It looks like the values changed are exactly the same as described by @jamisonderek in the Flipper Zero - SubGHz Data Rate video from 2023-06-03. I have verified that following the steps in the video yield the exact same configuration result, so I've referred to it as a source for explanation of the change.

Verification

  • The values in the subghz_device_cc1101_preset_ook_650khz_async_regs_better_q array should remain unchanged after preprocessing. No functional changes are expected, just better documentation/comments.

Checklist (For Reviewer)

  • PR has description of feature/bug
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@RogueMaster
Copy link
Owner

Seems this PR has code changes, not documentation, if you want to fix that I can merge it in...

@user890104
Copy link
Author

The changes do not change any of the preset data, it's just easier to read and understand named registers compared to register numbers. All other presets in the file are constructed in this way.
The following comparison shows that both versions of the AM_Q preset output the exact same bytes: https://onecompiler.com/c/3zsdct834

@RogueMaster
Copy link
Owner

Thank you!

@RogueMaster RogueMaster merged commit 659f907 into RogueMaster:420 Nov 3, 2023
@user890104 user890104 deleted the am_q_documentation branch November 3, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants