-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting for always reverting to online #7
Conversation
I tried your changes and they look good to me! I also appreciate you following the same variable naming style. However would it be possible for you to add your changes to Also thank you for taking time out to contribute to the plugin |
I updated both those files. Is there some way I should undo the changes to the file in the |
I'll undo those changes in I'll also do some refactoring on your branch before merging if you dont mind me doing that. again, thank you for your time putting these changes together |
also, in the changelog should I address you by your github username or some other username (like discord one maybe)? |
Thank you very much! Glad to contribute. Shall I close this pr, or wait till the update is released? |
Just GitHub is great, thanks. |
when i would merge this PR, it would close itself. so now you just have to wait till the update is released which i'll be done doing in a few hours |
Alright. Thank you again! |
This reverts commit f8dd5e9.
…ippets Co-authored-by: bobbyl140 <61990607+bobbyl140@users.noreply.github.com>
congratulations on your first PR! |
Implemented feature as described in #6.