Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for always reverting to online #7

Merged
merged 6 commits into from
Feb 1, 2022

Conversation

bobbyl140
Copy link
Contributor

Implemented feature as described in #6.

@RoguedBear
Copy link
Owner

I tried your changes and they look good to me! I also appreciate you following the same variable naming style.

However would it be possible for you to add your changes to src/AutoIdleOnAFK/config.json and src/AutoIdleOnAFK/index.js instead, since the file under release/ is generated from the code in src/

Also thank you for taking time out to contribute to the plugin

@RoguedBear RoguedBear linked an issue Feb 1, 2022 that may be closed by this pull request
@bobbyl140
Copy link
Contributor Author

I updated both those files. Is there some way I should undo the changes to the file in the release/ folder? Also, I was unsure how you would want the changelog to look, so I left that as it was. If you would like me to simply replace everything with a description of the new feature, I can do so.

@RoguedBear
Copy link
Owner

I'll undo those changes in release/ from my side. You can leave the changelog too since I'll be bundling your changes and a patch for #8 in one update.

I'll also do some refactoring on your branch before merging if you dont mind me doing that.

again, thank you for your time putting these changes together

@RoguedBear
Copy link
Owner

also, in the changelog should I address you by your github username or some other username (like discord one maybe)?

@bobbyl140
Copy link
Contributor Author

Thank you very much! Glad to contribute. Shall I close this pr, or wait till the update is released?

@bobbyl140
Copy link
Contributor Author

also, in the changelog should I address you by your github username or some other username (like discord one maybe)?

Just GitHub is great, thanks.

@RoguedBear
Copy link
Owner

Thank you very much! Glad to contribute. Shall I close this pr, or wait till the update is released?

when i would merge this PR, it would close itself. so now you just have to wait till the update is released which i'll be done doing in a few hours

@bobbyl140
Copy link
Contributor Author

Alright. Thank you again!

@RoguedBear RoguedBear changed the base branch from main to feature-0.3.0 February 1, 2022 14:48
@RoguedBear RoguedBear merged commit aaf90ef into RoguedBear:feature-0.3.0 Feb 1, 2022
@RoguedBear
Copy link
Owner

congratulations on your first PR!

@RoguedBear RoguedBear mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Device Support
2 participants