Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to strip quotes when normalizing #172

Merged
merged 8 commits into from
Sep 2, 2023
Merged

Add option to strip quotes when normalizing #172

merged 8 commits into from
Sep 2, 2023

Conversation

RohanNagar
Copy link
Owner

@RohanNagar RohanNagar commented Sep 2, 2023

Adds code for #168

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage: 98.55% and project coverage change: +0.17% 🎉

Comparison is base (1672468) 97.76% compared to head (ab712ab) 97.94%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #172      +/-   ##
============================================
+ Coverage     97.76%   97.94%   +0.17%     
- Complexity      326      358      +32     
============================================
  Files            12       13       +1     
  Lines           582      633      +51     
  Branches        153      172      +19     
============================================
+ Hits            569      620      +51     
  Partials         13       13              
Files Changed Coverage Δ
src/main/java/com/sanctionco/jmail/JMail.java 97.68% <98.00%> (+0.34%) ⬆️
src/main/java/com/sanctionco/jmail/Email.java 97.64% <100.00%> (+0.34%) ⬆️
...main/java/com/sanctionco/jmail/EmailValidator.java 100.00% <100.00%> (ø)
...ain/java/com/sanctionco/jmail/JmailProperties.java 100.00% <100.00%> (ø)
...ain/java/com/sanctionco/jmail/ValidationRules.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.1
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@RohanNagar RohanNagar merged commit 5409241 into master Sep 2, 2023
8 checks passed
@RohanNagar RohanNagar deleted the unquote branch September 2, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant