Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new settings to include/exclude the miscellaneous fees when generating penalty #84

Closed
4 tasks done
RoiJS opened this issue Jul 25, 2021 · 1 comment · Fixed by #85
Closed
4 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@RoiJS
Copy link
Owner

RoiJS commented Jul 25, 2021

On issue #52, a setting was introduced to specify the due date for miscellaneous fees, either same with the utility bills or rental fees. There is a condition that if the miscellaneous due date is the same with the rental fees then include the miscellaneous fees when checking for penalty. There might be a scenario where user would not want to include the miscellaneous fees when checking for penalty. To resolve this, we are going to introduce new setting on terms level that will include/exclude the miscellaneous fees when checking for penalty.

TODO:

  • On term details page particularly on Miscellaneous Settings panel, add new setting called "Include in Checking and Calculating Penalty". Make this setting only available if the Miscellaneous Due Date is set to same with the rental fees. If Miscellaneous Due Date is set to same with the rental fees and the new setting is activated then make sure to include the miscellaneous fees when checking for penalty. And if the penalty value type setting is set to Percentage, make sure to get the penalty percentage value on the sum of rental and miscellaneous fees.
  • Add new Miscellaneous Settings Panel on Terms Details page.
  • Update unit tests
  • Update online documentation
@RoiJS RoiJS self-assigned this Jul 25, 2021
@RoiJS RoiJS added the enhancement New feature or request label Jul 25, 2021
@RoiJS RoiJS added this to Ready for Development in Reserbiz via automation Jul 25, 2021
@RoiJS RoiJS added this to the July Update Improvements milestone Jul 25, 2021
@RoiJS RoiJS moved this from Ready for Development to In Progress in Reserbiz Jul 25, 2021
RoiJS pushed a commit that referenced this issue Jul 26, 2021
RoiJS pushed a commit that referenced this issue Jul 26, 2021
RoiJS pushed a commit that referenced this issue Jul 26, 2021
@RoiJS
Copy link
Owner Author

RoiJS commented Jul 26, 2021

The new setting is now implemented. Necessary changes for both unit tests and online documentation have already been implemented as well. Moving this issue to close now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Resebiz Online Help
Awaiting triage
1 participant