Set default-rank for all clans during creation in config #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoinujNosde
requested changes
Feb 1, 2024
src/main/java/net/sacredlabyrinth/phaed/simpleclans/SimpleClans.java
Outdated
Show resolved
Hide resolved
src/main/java/net/sacredlabyrinth/phaed/simpleclans/managers/SettingsManager.java
Outdated
Show resolved
Hide resolved
|
Thanks for contributing! |
- CLAN_DEFAULTRANK is now CLAN_DEFAULT_RANK - Default value for "default_rank" is now "recruit"
RoinujNosde
requested changes
Feb 1, 2024
src/main/java/net/sacredlabyrinth/phaed/simpleclans/managers/SettingsManager.java
Outdated
Show resolved
Hide resolved
- default_rank is now default-rank - path is now clan.default-rank
fixed, should build just fine now (for me it did) |
RoinujNosde
approved these changes
Feb 1, 2024
Tomut0
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a feature for server owners to set default rank for all newly created clans. Clan owners are able to set their own default ranks after creation if they so desire, but this lets server owners disable setdefaultrank and have a default rank preset.