Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancel block place/break event during preparation time #56

Closed
wants to merge 1 commit into from
Closed

cancel block place/break event during preparation time #56

wants to merge 1 commit into from

Conversation

Kawlxz
Copy link

@Kawlxz Kawlxz commented Oct 28, 2021

IImplementing the issue (#45) suggestion

@SrBedrock SrBedrock linked an issue Oct 28, 2021 that may be closed by this pull request
Cancelar quebra de blocos durante time.preparation #45
Closed
@Tomut0
Copy link
Collaborator

Tomut0 commented Oct 28, 2021

What if instead of having 2 classes (BlockPlaceListener and BlockBreakListener) implement the one –> BlockUpdateListener and move logic there? ☕

@RoinujNosde
Copy link
Owner

RoinujNosde commented Oct 28, 2021 •
edited

You are calling dm.getWarrior() twice. Call it once and save the value in a variable.

Also, put the block listener logic in a single class, like @Tomut0 suggested.

@Kawlxz
Copy link
Author

Kawlxz commented Oct 28, 2021

closed due to new request (#57) (because explained there)

@Kawlxz Kawlxz closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancelar quebra de blocos durante time.preparation
3 participants
@Kawlxz @Tomut0 @RoinujNosde