Use Symbol Tables for Completions #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwpearce
commented
Aug 28, 2023
markwpearce
commented
Aug 28, 2023
markwpearce
commented
Aug 28, 2023
markwpearce
changed the title
Comment on lines
+697
to
+700
| // make sure validation is complete | ||
| await this.validateAllThrottled(); | ||
| //wait for the validation cycle to settle | ||
| await this.onValidateSettled(); |
There was a problem hiding this comment.
This might have something to do with the issues with validations getting stuck. Just taking note...
Comment on lines
+975
to
+977
| if (await this.handleFileChange(project, change)) { | ||
| await this.validateAllThrottled(); | ||
| } |
There was a problem hiding this comment.
This might have something to do with the stuck validation cycle too. Just taking another note...
| @@ -834,21 +834,25 @@ export class Scope { | |||
| : new NamespaceType(nameSoFar); | |||
| if (previousNSType) { | |||
| // adding as a member of existing NS | |||
| previousNSType.addMember(nsNamePart, namespace.range, currentNSType, getTypeOptions.flags); | |||
| previousNSType.addMember(nsNamePart, { definingNode: namespace }, currentNSType, getTypeOptions.flags); | |||
There was a problem hiding this comment.
What was the need for the definingNode property? I'm not a huge fan of linking AST to types, would be nice to find a way to avoid this if possible.
TwitchBronBron
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes all completion logic to use symbol tables.
Other changes:
- Hack to get a parser from an AST Body - this is used to get the documentations tokens. I don't like how this is done (AST Node should not know about the Parser! -> It would be really useful to have a way to map functions to comments!NOTE:
There has been a significant performance loss in
Validatebenchmark.. I think it happened in commit: 81e6391